From: Daniel van Vugt <daniel.van.vugt@canonical.com>
Date: Fri, 23 Feb 2024 07:29:56 +0000 (+0800)
Subject: theme: Don't give login-dialog another background-color
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~281^2~1^2~107
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=d09509b2cbce0d21c68d40a765a0880743a3ef5e;p=gnome-shell.git

theme: Don't give login-dialog another background-color

Its parent `lockDialogGroup` has exactly the same background-color
set in the same file. Giving them both the same wasted render time on
overdraw, and caused multi-layer blending artifacts (slight flickering
of the grey background) when the login dialog fades in/out.

While the flicker can also be fixed using `set_offscreen_redirect`,
there's no point adding that overhead when the extra layer doesn't need
to be painted. Removing it halves the average render time of the login
animation.

Closes: https://bugs.launchpad.net/bugs/2036388
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3207>
---

diff --git a/data/theme/gnome-shell-sass/widgets/_login-lock.scss b/data/theme/gnome-shell-sass/widgets/_login-lock.scss
index ae3fc7d8d..87ed1cad9 100644
--- a/data/theme/gnome-shell-sass/widgets/_login-lock.scss
+++ b/data/theme/gnome-shell-sass/widgets/_login-lock.scss
@@ -21,8 +21,6 @@ $_gdm_dialog_width: 25em;
 // GDM Login Dialog
 // uses dark grey system styles
 .login-dialog {
-  background-color: $_gdm_bg;
-
   .login-dialog-prompt-entry {
     @extend %system_entry;
   }